SONARJAVA-6624 Fix S5738: Replace deprecated @EnableRuleMigrationSupport with JUnit 5 native APIs#5795
Closed
daniel-teuchert-sonarsource wants to merge 2 commits into
Conversation
…5 native APIs Migrate 12 test files from JUnit 4 @Rule/TemporaryFolder to JUnit 5 @tempdir Path, and drop @EnableRuleMigrationSupport (marked for removal). Helper methods in InputFileUtils and ExternalReportTestUtils updated to accept Path instead of TemporaryFolder. LogTester @rule removed from doc example tests where it was unused in assertions. Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
hashicorp-vault-sonar-prod
Bot
changed the title
Contributor
Removing TemporaryFolder/EnableRuleMigrationSupport imports from JavaSensorTest.java reduced the type error count by 6 (those were unresolvable types). Update the hardcoded expected value from 205 to 199. Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
|
Code Review ✅ ApprovedReplaces deprecated OptionsAuto-apply is off → Gitar will not commit updates to this branch. Comment with these commands to change the behavior for this request:
Was this helpful? React with 👍 / 👎 | Gitar |
daniel-teuchert-sonarsource
deleted the
fix/sonarqube-s5738-remove-deprecated-enable-rule-migration-support
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@EnableRuleMigrationSupport(java:S5738 — deprecated class marked for removal) from 12 test files@Rule TemporaryFolderto JUnit 5@TempDir Pathacross all affected testsInputFileUtils.addFile()andExternalReportTestUtils.generateReport()helper signatures fromTemporaryFoldertoPath@Rule LogTesterfrom two doc example tests (was only present for debug viewing, never asserted on)Test plan
@EnableRuleMigrationSupport🤖 Generated with Claude Code